Repository navigation
feat(work): add typed issue intake and conservative claim import (#1017) - #1126
Conversation
The per-PR marker was created inside `lock`, so "first access" was really "marker file missing". The only thing named `.lock`, a marker is the file an operator or a cleanup step would delete. Losing it made every later `claim` take the create-only branch, which fails on the intact, authoritative state file: that PR's claims were permanently bricked although its attempts were still on disk and had to be counted. Creation now keys on the authoritative state file itself, so a missing marker can never block a reservation. Whether a PR has ever been reserved is a separate, explicit fact: a private `<n>.board-claim.created` marker written only after the state file is durable, so it can only under-claim, never hide a cap. First access is unaffected; a state file lost after that marker still fails closed, so a deleted reservation cannot reset the daily cap. Also drops the now-unused `fresh` return value and reads private markers with an explicit read-only open, and documents the rule in oxa/docs/work.md. Tests: board_claims::lost_marker_keeps_the_cap_but_lost_state_still_fails_closed covers both directions; the existing poisoned-state and concurrent-process cases still pin fail-closed first access and single reservation.
|
@codex review |
|
@codex security review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
First-pass review by oxa → oxc →
TIER: T3 🤖 Generated with Claude Code (oxa review lane) |
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Board-core landing summary for #1017 / #927: the initial rules, redaction/model, durable claims and manual controls are merged (#1021, #1039, #1044, #1037, #1121, #1112), and #1126 now lands typed issue intake/import plus the reviewer-role repair at ca7e3ff. Exact merge-group CI44158022707 passed; code/security review cleared source d6c94a7. Landed board source/tests match that reviewed source. All histories, helper deltas and branches remain. The board remains default OFF with cap3. No native activation, GitHub mirror writes, script cutover or helper start was performed. Work2/N0 own the existing consumer/partition/import/runtime gates; intake and helper starts remain paused under the owner's current policy. Previously assigned assistance: #684 is merged; #759/#685/#397/#407 remain open drafts with current-head lane successes. Their current review/ready qualification and, for execution/publication paths, the explicit narrow execution/auth read still remain. Exact-head digest was sent to the coordinator/source owner; no competing source changes or new review request was made. |
Adds typed issue intake and conservative claim bootstrap for #1017 / design #927, with role-safe issue admission. T3: private persistent enforcement state. The assignment/manual APIs and witness repair have landed through #1121/#1112; their complete histories are retained. Own slice against the retained parent is exactly 374 additions / 26 deletions = 400 changed lines.
GitHub::snapshot() -> Result<Snapshot>returns real PR and Issue inputs together. Issue fields are number, frozen source revision, release_pinned, trusted approved, and has_open_pull_request. Approved issues without an open PR receive BuildIssue; others receive WaitIssue. Cross-kind duplicate numbers fail the complete read. For issue actions Entry.head is provenance, never a checkout SHA; helper BASE remains main. The caller applies the SAME prepared partition predicate to both lists. One enabled source call, none disabled; existing PR adapters remain compatible. Two exhaustive web labels cover the new actions.Issue builds require registered Builder/Owner authority through claim_for or authenticated assign. The legacy holder-only Claims::claim now refuses BuildIssue entirely; a holder string cannot prove a role. Existing legacy PR admission is unchanged. The regression establishes Reviewer-only refusal through claim_for, then refusal through legacy claim on the same fresh unconfigured issue, then successful Builder admission. The initial legacy grant is reproduced before the fix; no existing lease can mask the check.
Bootstrap, with activation OFF:
Removes: PR-only intake as the sole board input, and role-unaware issue admission through the compatibility API. No existing feature, test, assertion, documentation, helper delta or branch was removed. Eight blank lines in newly added helpers/tests were compacted to retain the line bound. No new planner/store/registry/provider/queue, process launch, board GitHub writes or activation.
Validation:
Ready for normal review. Runtime/intake/helper starts remain OFF/paused; only admitted landing work continues.